Address spurious Microsoft compiler warnings #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jainamt
reviewed
Oct 21, 2020
| @@ -1248,7 +1248,7 @@ static JSONStatus_t search( char * buf, | |||
| size_t * outValueLength ) | |||
| { | |||
| JSONStatus_t ret = JSONPartial; | |||
| size_t i = 0, key, keyLength, value, valueLength; | |||
| size_t i = 0, key, keyLength, value = 0, valueLength = 0; | |||
There was a problem hiding this comment.
There are no warnings for key and keyLength. I think it is better to enlist the compiler to tell me when I use an uninitialized variable, than to initialize everything and rob myself of that check. The only problem is when the compiler gets it wrong, as the Microsoft compiler does here.
There was a problem hiding this comment.
Do you think that it's good practice to just initialize everything anyways as part of our style?
There was a problem hiding this comment.
No, not everything. I think the practice can do more harm than good in some cases.
sarenameas
approved these changes
Nov 2, 2020
aggarg
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different compilers seem to have different capacities to recognize use of an uninitialized variable. The GNU toolchain gives no warnings, but the Microsoft compiler does. Upon inspection, the variables are only ever used after being set, but it is simpler to provide throwaway defaults than to mute the warning.