Add CBMC proof-running GitHub Action #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
karkhaz
force-pushed
the
kk-add-github-action
branch
9 times, most recently
from
5e6a762 to
f009a08
Compare
karkhaz
force-pushed
the
kk-add-github-action
branch
from
f009a08 to
4afcd3a
Compare
archigup
reviewed
Mar 3, 2023
test/cbmc/proofs/run-cbmc-proofs.py
Outdated
| if proc.returncode: | ||
| logging.critical("Could not add tool version printing job") | ||
| sys.exit(1) | ||
| #def add_tool_version_job(): |
There was a problem hiding this comment.
Why is this code commented out? Should it be removed?
There was a problem hiding this comment.
Hi Archit, I'm planning on re-enabling this for all repositories (not all of them currently have it), but in a separate PR. Is that OK?
There was a problem hiding this comment.
That is fine; in that case would be best for this PR to remove the commented out code, and can add it back in the other PR when ready
This commit adds a GitHub Action that runs the CBMC proofs in this repository upon pushes and pull requests
karkhaz
force-pushed
the
kk-add-github-action
branch
from
4afcd3a to
0986ef6
Compare
archigup
approved these changes
Mar 3, 2023
AniruddhaKanhere
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a GitHub Action that runs the CBMC proofs upon every push and pull request. This is intended to replace the current CBMC CI.