-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Internal Functions for Enhanced Usability #167
Conversation
Thanks for the PR! Seems good, though should rename the existing functions to HTTPClient_SendHttpHeaders, HTTPClient_SendHttpData, etc., instead of adding a wrapper function. Seems that in CI, unit tests are hitting an issue since there are "^M" characters at the end of two of the lines. The actions have a formatting patch you can apply, or I can do so for you if you would prefer. With the above, the only thing left would be to add the doc comments to the functions for doxygen, which we can help with if needed. |
/bot run formatting |
exposed internal function, added areHeadersComplete
Hello @archigup, I've updated the functions and added |
Hello @cryi, Could you enable maintainers to edit this pull request so I can add documentation? |
Thank you, @cryi. I have added the documentation and updated the code size and CBMC. |
Description
In this Work-In-Progress (WIP) PR, we have showcased a sample implementation that exposes the internal functions
sendHttpHeaders
,sendHttpData
, andreceiveAndParseHttpResponse
within the coreHTTP library. Exposing these functions aims to provide developers with more control over the HTTP communication process, enabling the support for chunked body reads and writes, streaming, and other advanced HTTP functionalities which are essential for building more sophisticated applications atop coreHTTP.Test Steps
To reproduce the changes, follow these steps:
Checklist:
Related Issue
#166
#160By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.