-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MISRA Compliance Update #132
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to the repo, slight changes to the client for MISRA/Coverity compliance.
Skptak
changed the title
Misra updates after meeting with Senior SDE
MISRA Compliance Update
Jul 22, 2022
Removed MISRA warnings in caseInsensitiveStringCmp function. Changed in line comments to reflect new MISRA.md format. Modified misra.config reasons.
toupper() was causing the CBMC test to fail. Through much trial and error it appears there isn't a way around it. So adding in a MISRA exception for the rule related to that cast.
archigup
reviewed
Aug 1, 2022
paulbartell
reviewed
Aug 1, 2022
paulbartell
reviewed
Aug 1, 2022
paulbartell
reviewed
Aug 1, 2022
paulbartell
reviewed
Aug 2, 2022
paulbartell
reviewed
Aug 2, 2022
paulbartell
reviewed
Aug 2, 2022
…on to see if it passes github checks
strncpy(), removed a rule that wasn't needed from the config file, cleaning up comments.
ravibhagavandas
approved these changes
Aug 15, 2022
aggarg
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.