Add function prototypes for exported functions to CBMC proof harnesses #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markrtuttle
force-pushed
the
proof-static-function-prototypes
branch
from
d9428ca to
2a0f410
Compare
yourslab
approved these changes
Sep 5, 2021
cobusve
approved these changes
Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit adds function protocols to CBMC proof harnesses for static functions exported with
--export-file-local-symbols. Prior to this commit, the harnesses were invoking the static function by its mangled name without declaring the mangled named, the compiler was inferring a default type for the declaration that conflicted with the type of the definition, and the linker was silently refusing to update the symbol table with the definition due to the type conflict.