Fix one typical misusage of CMock. #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMock has three policies when dealing with pointer: 1. compare_ptr : compare the pointer itself; 2. compare_data : compare the data which is pointed by pointer; 3. smart : compare the pointer itself, or compare the data; By default, CMock use compare_data policy. Most test cases in FreeRTOS need to compare the pointer itself, and we haven't use CMock properly. For example, one test case of vTaskResume is wrong, because current CMock compares the data pointed by pointer, so the error didn't exposed. There are so many misusage need to fix, it will take a lot of work. I'm here to fix one typical misusage first.
n9wxu
approved these changes
Nov 8, 2023
2 tasks
every-breaking-wave
pushed a commit
to every-breaking-wave/FreeRTOS
that referenced
this pull request
Nov 15, 2024
* Remove hardware dependence in portmacros.h The IAR MSP430X port `#include "msp430.h"` which pulls all the hardware register definitions into anything which `#include "FreeRTOS.h"`. This removes that hardware dependency "leak" by removing the header file and re-defining the `portDISABLE_INTERRUPTS()` and `portENABLE_INTERRUPTS()` macros in terms of `__asm`. * Code review suggestions Signed-off-by: Gaurav Aggarwal <[email protected]> --------- Signed-off-by: Gaurav Aggarwal <[email protected]> Co-authored-by: Gaurav-Aggarwal-AWS <[email protected]> Co-authored-by: Gaurav Aggarwal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CMock has three policies when dealing with pointer:
By default, CMock use compare_data policy.
Most test cases in FreeRTOS need to compare the pointer itself, and we haven't use CMock properly.
For example, one test case of vTaskResume is wrong, and because CMock compares the data pointed by pointer currently, so the error didn't exposed.
There are so many misusage need to fix, it will take a lot of work. I'm here to fix one typical misusage first.
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.