Unit test fix for PR#625 #1049
Closed
Unit test fix for PR#625 #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
|
@kar-rahul-aws Thanks for doing this. This looks exactly like what I expected so seems good to me! |
|
@kar-rahul-aws Ultimately I think that these tests probably need to be moved into the FreeRTOS-Kernel repository, so these unit tests can be updated atomically with the source. Until then, we can work around this problem in the following steps:
I can create the PR if your team thinks this is acceptable. |
|
Duplicate PR has been merged, hence closing this issue. |
every-breaking-wave
pushed a commit
to every-breaking-wave/FreeRTOS
that referenced
this pull request
Nov 15, 2024
The variable `xPortRunning` is now updated before starting the first task. It fixes the following issue - https://forums.freertos.org/t/possible-bug-in-the-way-prvtimertask-thread-function-is-started-in-win32-port/19959/ Signed-off-by: Gaurav Aggarwal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds fix for Unit Test for FreeRTOS+Kernel PR#625 and duplicate PR#719
Test Steps
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.