-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ipconfigEMAC_TASK_HOOK macro to STMH7xx network interface #1176
Conversation
@@ -87,6 +87,9 @@ | |||
#define niEMAC_HANDLER_TASK_PRIORITY configMAX_PRIORITIES - 1 | |||
#endif | |||
|
|||
#ifndef ipconfigEMAC_WATCHDOG_TIMER |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we name it so that it does not seem specific to watchdog? The reason is that someone may want to use it for a different purpose too. How about something like iptraceEMAC_TASK_ITERATION
or iptraceEMAC_TASK_HOOK
?
Signed-off-by: Gaurav Aggarwal <[email protected]>
Signed-off-by: Gaurav Aggarwal <[email protected]>
The above PR went too fast, I missed. |
@htibosch If I understand correctly, ipconfigWATCHDOG_TIMER is called from the IP task and thereby enables the application to monitor the IP task. On the other hand, this change enables the application to monitor the EMAC task. Or did I miss something? |
About the other PR 1178, this is how you can obtain the task handle of the EMAC task: TaskHandle_t xHandle = xTaskGetHandle( niEMAC_HANDLER_TASK_NAME ); It will return the handle of the EMAC handler task. There is no need for a new function The existing application hook extern void watchdog_timer( TaskHandle_t pxTask );
#define ipconfigWATCHDOG_TIMER() \
do{ \
watchdog_timer( xTaskGetCurrentTaskHandle() ); \
} while( 0 ) |
Add ipconfigEMAC_TASK_HOOK macro to allow for configurable watchdog timer for STMH7xx MCUs
Description
ipconfigEMAC_TASK_HOOK
macro, which defaults to a no-op but can be overridden inFreeRTOSIPConfig.h
.ipconfigEMAC_TASK_HOOK()
call in the Ethernet status checking code to enable optional watchdog timer functionality.ipconfigEMAC_TASK_HOOK
inFreeRTOSIPConfig.h
to enable or disable the watchdog timer, providing greater flexibility in managing Ethernet operations.Test Steps
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.