Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing library to use loopback device #1020

Merged
merged 32 commits into from
Oct 6, 2023
Merged

Preparing library to use loopback device #1020

Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
1803d90
Preparing library to use loopback device
htibosch Sep 6, 2023
91badc9
Repaired FreeRTOS_AddEndPoint() as well
htibosch Sep 6, 2023
a57b099
Minor changes for Doxygen
htibosch Sep 7, 2023
e5a8f60
Uncrustify: triggered by comment.
actions-user Sep 7, 2023
e9f9126
Merge branch 'main' into prepare_for_loopback
moninom1 Sep 7, 2023
87c517d
Added IPv6.h and removed call to xIsIPv6Loopback
htibosch Sep 7, 2023
2422335
Conditional compilation of xIPv6_GetIPType()
htibosch Sep 7, 2023
9104b2e
Do not call xBadIPv4Loopback() when IPv4 is not enabled
htibosch Sep 8, 2023
f7d2e35
Repaired unit tests
htibosch Sep 8, 2023
83f34fd
Merge branch 'main' into prepare_for_loopback
htibosch Sep 10, 2023
5669fd8
In FreeRTOS_AddEndPoint(), set next to NULL
htibosch Sep 12, 2023
855d6d5
One more change in FreeRTOS_AddNetworkInterface()
htibosch Sep 13, 2023
085741c
FreeRTOS_FillEndPoint: save pxNext before clearing entire endpoint st…
htibosch Sep 13, 2023
35a61c1
Uncrustify: triggered by comment.
actions-user Sep 13, 2023
c706b49
Merge branch 'main' into prepare_for_loopback
tony-josi-aws Sep 13, 2023
364bc05
Changes after review by Shub
htibosch Sep 14, 2023
5b24042
Changes after review by Shub, part 2
htibosch Sep 14, 2023
a0b59ff
Uncrustify: triggered by comment.
actions-user Sep 14, 2023
3c97367
Merge branch 'main' into prepare_for_loopback
moninom1 Sep 19, 2023
7cdbef2
Replace pxUDPPacket with pxIPacket in function prvAllowIPPacketIPv4()
htibosch Sep 19, 2023
c29f055
utest: replace xIPv6UnspecifiedAddress with FreeRTOS_in6addr_any
htibosch Sep 19, 2023
5240680
Merge branch 'main' into prepare_for_loopback
htibosch Sep 22, 2023
31da177
Merge branch 'main' into prepare_for_loopback
htibosch Sep 26, 2023
c2cd991
Checked unit-tests and coverage
htibosch Sep 26, 2023
3b9a259
ut: Repaired GetIPType loopback test
htibosch Sep 27, 2023
d695740
Update test/unit-test/FreeRTOS_IPv6_ConfigDriverCheckChecksum/FreeRTO…
htibosch Sep 27, 2023
d7ee3c2
Update test/unit-test/FreeRTOS_IPv6/ut.cmake
htibosch Sep 27, 2023
c05141f
Remove test for 'ipIPv4_FRAME_TYPE'
htibosch Sep 28, 2023
a73a8c1
Repairing tu again
htibosch Sep 29, 2023
20f16c2
Merge branch 'main' into prepare_for_loopback
moninom1 Oct 4, 2023
1150510
Merge branch 'main' into prepare_for_loopback
htibosch Oct 5, 2023
16352be
Merge branch 'main' into prepare_for_loopback
moninom1 Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions source/FreeRTOS_Routing.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,10 +241,6 @@ struct xIPv6_Couple
{
NetworkEndPoint_t * pxIterator = NULL;

/* This end point will go to the end of the list, so there is no pxNext
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah i think this needs to be removed in the case the endpoint is already present on the list.

* yet. */
pxEndPoint->pxNext = NULL;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But i think we should also add pxEndPoint->pxNext = NULL; in line 262 in case there is no endpoint in the list

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also can we move commit as a separate PR?

Copy link
Contributor Author

@htibosch htibosch Sep 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But i think we should also add pxEndPoint->pxNext = NULL; in line 262 in case there is no endpoint in the list

That is 10 points for you, Monika, thanks! Although we assume that endpoints have been cleared, we can not count on it.

/* Double link between the NetworkInterface_t that is using the addressing
* defined by this NetworkEndPoint_t structure. */
pxEndPoint->pxNetworkInterface = pxInterface;
Expand Down Expand Up @@ -278,6 +274,7 @@ struct xIPv6_Couple

if( pxIterator->pxNext == NULL )
{
pxEndPoint->pxNext = NULL;
pxIterator->pxNext = pxEndPoint;
break;
}
Expand Down