Change vSetNotAllNetworksUp into a more generic vSetAllNetworksUp

FreeRTOS · Oct 5, 2023 · 9925b16 · 9925b16
1 parent 6408ee7
commit 9925b16
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/source/FreeRTOS_IP_Timers.c b/source/FreeRTOS_IP_Timers.c
@@ -328,7 +328,7 @@ void vCheckNetworkTimers( void )
                 }
             }
 
-            xAllNetworksUp = xUp;
+            vSetAllNetworksUp( xUp );
         }
     }
 }
@@ -606,11 +606,10 @@ void vIPSetARPResolutionTimerEnableState( BaseType_t xEnableState )
 /*-----------------------------------------------------------*/
 
 /**
- * @brief Mark that at least one interface is down so that the 'xNetworkTimer' is checked.
- *        Whenever the timer expires, all interfaces that are down will get a new NetworkDown
- *        event.
+ * @brief Mark whether all interfaces are up or at least one interface is down.
+ *        If all interfaces are up, the 'xNetworkTimer' will not be checked.
  */
-void vSetNotAllNetworksUp( void )
+void vSetAllNetworksUp( BaseType_t xIsAllNetworksUp )
 {
-    xAllNetworksUp = pdFALSE;
+    xAllNetworksUp = xIsAllNetworksUp;
 }
diff --git a/source/FreeRTOS_IP_Utils.c b/source/FreeRTOS_IP_Utils.c
@@ -961,7 +961,8 @@ void prvProcessNetworkDownEvent( struct xNetworkInterface * pxInterface )
     }
     else
     {
-        vSetNotAllNetworksUp();
+        /* At least one interface is down. */
+        vSetAllNetworksUp( pdFALSE );
 
         /* Nothing else to do. When the 'xNetworkTimer' expires, all interfaces
          * with bits.bInterfaceUp cleared will get a new 'eNetworkDownEvent' */

diff --git a/test/unit-test/FreeRTOS_IP_Utils/FreeRTOS_IP_Utils_utest.c b/test/unit-test/FreeRTOS_IP_Utils/FreeRTOS_IP_Utils_utest.c
@@ -581,7 +581,7 @@ void test_prvProcessNetworkDownEvent_InterfaceInitFail( void )
 
     vDHCPStop_Expect( &xEndPoint );
 
-    vSetNotAllNetworksUp_Expect();
+    vSetAllNetworksUp_Expect( pdFALSE );
 
     prvProcessNetworkDownEvent( &xInterface );
 }