Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MISRA C 2012 Rule 13.2 Violations #979

Merged
merged 19 commits into from
Feb 13, 2024

Conversation

bradleysmith23
Copy link
Contributor

Description

As stated in MISRA C 2012 - "Between any two sequence points or within any full expression (...) There shall be no more than one read access with the volatile-qualified type"
The recommended remediation by MISRA is to only access volatiles with assignment statements whenever possible.

Test Steps

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bradleysmith23 bradleysmith23 requested a review from a team as a code owner February 1, 2024 22:30
@bradleysmith23
Copy link
Contributor Author

/bot run formatting

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bd65223) 93.52% compared to head (e80fdc5) 93.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #979   +/-   ##
=======================================
  Coverage   93.52%   93.53%           
=======================================
  Files           6        6           
  Lines        3199     3200    +1     
  Branches      889      889           
=======================================
+ Hits         2992     2993    +1     
  Misses         92       92           
  Partials      115      115           
Flag Coverage Δ
unittests 93.53% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

chinglee-iot
chinglee-iot previously approved these changes Feb 5, 2024
@bradleysmith23
Copy link
Contributor Author

/bot run formatting

@bradleysmith23 bradleysmith23 requested a review from aggarg February 5, 2024 20:10
@bradleysmith23
Copy link
Contributor Author

/bot run formatting

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kar-rahul-aws kar-rahul-aws merged commit 8cfa715 into FreeRTOS:main Feb 13, 2024
18 checks passed
laroche pushed a commit to laroche/FreeRTOS-Kernel that referenced this pull request Apr 18, 2024
* mbedtls is removed in this folder. Update the readme.txt accordingly.

Co-authored-by: Gaurav-Aggarwal-AWS <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants