Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for unpaired critical section in vTaskSuspend #959

Merged

Conversation

chinglee-iot
Copy link
Member

@chinglee-iot chinglee-iot commented Jan 23, 2024

Update for unpaired critical section in vTaskSuspend

Description

  • Move the taskEXIT_CRITICAL out of the macro to improve readability.

Unit test is updated in this PR : FreeRTOS/FreeRTOS#1160

Test Steps

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@chinglee-iot chinglee-iot requested a review from a team as a code owner January 23, 2024 11:28
@chinglee-iot chinglee-iot marked this pull request as draft January 23, 2024 11:36
@chinglee-iot
Copy link
Member Author

This PR will be ready for review after unit test fixed.

@chinglee-iot chinglee-iot marked this pull request as ready for review January 23, 2024 15:22
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4d9f652) 93.42% compared to head (08ee9b0) 93.42%.

Files Patch % Lines
tasks.c 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #959      +/-   ##
==========================================
- Coverage   93.42%   93.42%   -0.01%     
==========================================
  Files           6        6              
  Lines        3196     3194       -2     
  Branches      886      885       -1     
==========================================
- Hits         2986     2984       -2     
  Misses        103      103              
  Partials      107      107              
Flag Coverage Δ
unittests 93.42% <91.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chinglee-iot chinglee-iot merged commit 72c7d86 into FreeRTOS:main Jan 24, 2024
14 of 16 checks passed
@chinglee-iot chinglee-iot deleted the update-vTaskSuspend-readibility branch January 24, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants