Fix build with modern GCC #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Forty-Bot |
|
On 12/22/23 05:10, Rahul Kar wrote:
Hi @Forty-Bot <https://github.com/Forty-Bot>
Please let us know the version of the msp430-gcc compiler you are using. It will be useful to reproduce the issue you are facing.
Thanks.
$ msp430-elf-gcc --version
msp430-elf-gcc (GCC) 13.1.0
Copyright (C) 2023 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #933 +/- ##
=======================================
Coverage 93.78% 93.78%
=======================================
Files 6 6
Lines 3186 3186
Branches 885 885
=======================================
Hits 2988 2988
Misses 91 91
Partials 107 107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@Forty-Bot can you bring this branch up to date? Then we can merge and address the other PR. |
Apparently at some point in the past, GCC (or TI's GCC) used to define these attributes. Define them ourselves so that we can compile the demo application.
If a return type of a function is not specified, it defaults to int. Set the return type of interrupts to void to avoid warnings.
portPOINTER_SIZE_TYPE defaults to uint32_t if undefined. Define it to uint16_t, which is correct for this port.
|
n9wxu
approved these changes
Dec 22, 2023
kstribrnAmzn
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building the msp430_GCC demo produces several errors and compiler warnings. These patches fix the errors and address the warnings.