Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coverity scan build and upload to single step #902

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

tony-josi-aws
Copy link
Member

Description

This PR updates the coverity scan yml script to do the coverity scan build and upload to single step.

Test Steps

Tested on fork

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@tony-josi-aws tony-josi-aws requested a review from a team as a code owner November 24, 2023 10:46
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Skptak
Copy link
Member

Skptak commented Nov 24, 2023

Either this or #903 should fix this issue
I introduced this bug when splitting the creation of the tar file and the uploading of it into separate steps. I had split these into separate steps so that if future changes were made to use the created coverity report that the creation and upload of it were seperated.

The tar file needs to be moved out of the build directory if used in a following step. Or the following step needed to move into the build directory, as is done in the first directory.

I approved this PR as this will also fix the current problem with this scan failing.

@tony-josi-aws tony-josi-aws merged commit 61f35dc into FreeRTOS:main Nov 27, 2023
15 checks passed
@tony-josi-aws tony-josi-aws mentioned this pull request Nov 27, 2023
2 tasks
@kar-rahul-aws kar-rahul-aws mentioned this pull request Nov 28, 2023
2 tasks
laroche pushed a commit to laroche/FreeRTOS-Kernel that referenced this pull request Apr 18, 2024
Updates the demo .cproj file to account for new
paths since 3P restructure. Also enables the xTaskGetCurrentTaskHandle
include which is needed for building.

Inspired by - https://forums.freertos.org/t/avr-gcc-warning-extra-tokens-at-end-of-undef-in-porthardware-h/16365/3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants