-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SMP template port and example #900
Add SMP template port and example #900
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #900 +/- ##
=======================================
Coverage 93.64% 93.64%
=======================================
Files 6 6
Lines 3179 3179
Branches 885 885
=======================================
Hits 2977 2977
Misses 95 95
Partials 107 107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All current changes are good enough as SMP template. Approve in advance.
I'll suggest to have one readme document in examples/sample_configuration/smp to describe the configurations we should take care while setting SMP port.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add both cmake builds to the CI checks if this has not been done. Then I will approve.
…inglee-iot/FreeRTOS-Kernel into add-smp-template-port-example
b8df01c
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is actually a great idea for how to handle this, thanks for doing this!
Add SMP template port and example
Description
The SMP template port shares of the same template port for single core. The port macros and implementation differences are separated by compile option
configNUMBER_OF_CORES
. Sharing the same port template helps user to identify the port differences between single core and SMP. A sample configuration file for SMP with minimal configuration change is also provided. The example project with cmake is updated to consume the template port and sample configuration to provide compilable project.The configuration added for SMP is listed below
As single core template port, the port is expected to be used for:
Test Steps
To build the example project for SMP template port:
smp_example
should be generated in the build folder.Checklist:
I have tested my changes. No regression in existing tests.I have modified and/or added unit-tests to cover the code changes in this Pull Request.Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.