Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade msvc port to winsock2 #895

Merged
merged 15 commits into from
Nov 28, 2023
Merged

Conversation

Skptak
Copy link
Member

@Skptak Skptak commented Nov 16, 2023

Description

MBedTLS swaps to using WinSock2.h in their files after the V3.3.0 Version.
Upgrade the MSVC port to use WinSock2.h inorder to be compatible with future mbedtls releases.

Test Steps

Ran tests in FreeRTOS/FreeRTOS

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Skptak Skptak requested a review from a team as a code owner November 16, 2023 22:54
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (147f34a) 93.64% compared to head (bc6620c) 93.64%.

❗ Current head bc6620c differs from pull request most recent head 77b4dca. Consider uploading reports for the commit 77b4dca to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #895   +/-   ##
=======================================
  Coverage   93.64%   93.64%           
=======================================
  Files           6        6           
  Lines        3179     3179           
  Branches      885      885           
=======================================
  Hits         2977     2977           
  Misses         95       95           
  Partials      107      107           
Flag Coverage Δ
unittests 93.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Skptak Skptak force-pushed the upgradeMSVCPortToWinsock2 branch from c3caa11 to 3cf56dd Compare November 28, 2023 14:03
@Skptak Skptak force-pushed the upgradeMSVCPortToWinsock2 branch from 3cf56dd to 202d9e8 Compare November 28, 2023 14:08
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Skptak Skptak merged commit 6a41432 into FreeRTOS:main Nov 28, 2023
@Skptak Skptak deleted the upgradeMSVCPortToWinsock2 branch December 19, 2023 13:06
laroche pushed a commit to laroche/FreeRTOS-Kernel that referenced this pull request Apr 18, 2024
* Fix IAR GCC build for Qemu MPS2

* Add removed file

* set trace facility to none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants