Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eTaskConfirmSleepModeStatus for smp. #893

Merged

Conversation

Moral-Hao
Copy link
Contributor

@Moral-Hao Moral-Hao commented Nov 15, 2023

Description

In smp, every core has a idle task.
So the count of non application tasks(idle tasks) should be number of cores.

Test Steps

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Moral-Hao Moral-Hao requested a review from a team as a code owner November 15, 2023 14:14
@chinglee-iot chinglee-iot self-assigned this Nov 16, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dc09a3d) 93.51% compared to head (43a7011) 93.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #893      +/-   ##
==========================================
+ Coverage   93.51%   93.67%   +0.15%     
==========================================
  Files           6        6              
  Lines        3177     3177              
  Branches      884      884              
==========================================
+ Hits         2971     2976       +5     
+ Misses         99       94       -5     
  Partials      107      107              
Flag Coverage Δ
unittests 93.67% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@chinglee-iot chinglee-iot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR FreeRTOS/FreeRTOS#1118 in FreeRTOS/FreeRTOS added a regression test case for SMP to verify the changes in this PR.

@moninom1 moninom1 changed the title fix eTaskConfirmSleepModeStatus for smp. Fix eTaskConfirmSleepModeStatus for smp. Nov 16, 2023
@Skptak Skptak merged commit 5f2bb1b into FreeRTOS:main Nov 16, 2023
@Moral-Hao Moral-Hao deleted the fix_eTaskConfirmSleepModeStatus_for_smp branch November 19, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants