Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Portable/Rowley Formatting #884

Merged
merged 6 commits into from
Nov 23, 2023
Merged

Conversation

Skptak
Copy link
Member

@Skptak Skptak commented Nov 8, 2023

Description

Revert PR #768 on Rowley Ports

Test Steps

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Skptak Skptak requested a review from a team as a code owner November 8, 2023 23:10
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8d1da77) 93.67% compared to head (911a918) 93.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #884   +/-   ##
=======================================
  Coverage   93.67%   93.67%           
=======================================
  Files           6        6           
  Lines        3177     3177           
  Branches      884      884           
=======================================
  Hits         2976     2976           
  Misses         94       94           
  Partials      107      107           
Flag Coverage Δ
unittests 93.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Skptak Skptak mentioned this pull request Nov 8, 2023
2 tasks
Copy link
Member

@chinglee-iot chinglee-iot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared with commit before #768
d6bccb1 | 2023-09-05 | Gaurav-Aggarwal-AWS | Fix heap address calculation issue (#781)

d6bccb1...Skptak:FreeRTOS-Kernel:fixRowleyFormatting

The three files are exactly the same.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aggarg aggarg merged commit 9a2ce91 into FreeRTOS:main Nov 23, 2023
17 checks passed
@Skptak Skptak deleted the fixRowleyFormatting branch December 19, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants