Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add portMEMORY_BARRIER() to RX MCU ports #864

Merged
merged 14 commits into from
Nov 29, 2023

Conversation

Skptak
Copy link
Member

@Skptak Skptak commented Oct 26, 2023

Description

Add the provided portMEMORY_BARRIER() from #854 to the Renesas RX MCU Ports.

Test Steps

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

#854

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a41432) 93.64% compared to head (9fc23d1) 93.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #864   +/-   ##
=======================================
  Coverage   93.64%   93.64%           
=======================================
  Files           6        6           
  Lines        3179     3179           
  Branches      885      885           
=======================================
  Hits         2977     2977           
  Misses         95       95           
  Partials      107      107           
Flag Coverage Δ
unittests 93.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kar-rahul-aws
Copy link
Member

Hi @Skptak
Since Renesas/SH2A_FPU is not a RX MCU, can we remove the change for the same ?

@Skptak
Copy link
Member Author

Skptak commented Nov 8, 2023

@kar-rahul-aws I have reverted this change from the SH2A_FPU portmacro.h file.

kar-rahul-aws
kar-rahul-aws previously approved these changes Nov 16, 2023
@Skptak Skptak requested a review from kar-rahul-aws November 28, 2023 18:57
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kar-rahul-aws kar-rahul-aws merged commit 6a9f5a2 into FreeRTOS:main Nov 29, 2023
17 checks passed
@Skptak Skptak deleted the rxPortMemoryBarrier branch December 19, 2023 13:06
laroche pushed a commit to laroche/FreeRTOS-Kernel that referenced this pull request Apr 18, 2024
FreeRTOS#864)

* added correct trap_handler initialization in main.c

Co-authored-by: Joseph Julicher <[email protected]>
Co-authored-by: Kody Stribrny <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants