Rename "CPU" to "Core" #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit renames "CPU" to "Core" for any public facing API for consistency with other SMP related APIs (e.g., "configNUMBER_OF_CORES").
|
@aggarg @chinglee-iot Do we need to add some compatibility macros if there hasn't been a SMP capable release of FreeRTOS thus far? |
|
@Dazza0 - We do not need backward compatibility macros as there is no release with SMP yet. |
chinglee-iot
approved these changes
Oct 23, 2023
aggarg
approved these changes
Oct 23, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #849 +/- ##
=======================================
Coverage 93.64% 93.64%
=======================================
Files 6 6
Lines 2549 2549
Branches 608 608
=======================================
Hits 2387 2387
Misses 107 107
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
n9wxu
pushed a commit
to n9wxu/FreeRTOS-Kernel
that referenced
this pull request
Oct 26, 2023
This commit renames "CPU" to "Core" for any public facing API for consistency with other SMP related APIs (e.g., "configNUMBER_OF_CORES"). Co-authored-by: Gaurav-Aggarwal-AWS <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SMP is enabled/disabled via the
configNUMBER_OF_CORESoption. This PR simply renames all occurrences ofCPUtoCorein any public facing API for naming consistency. The following APIs have been renamed:traceENTER_xTaskGetCurrentTaskHandleCPU->traceENTER_xTaskGetCurrentTaskHandleForCorexTaskGetCurrentTaskHandleCPU->xTaskGetCurrentTaskHandleForCoreThis commit renames "CPU" to "Core" for any public facing API for consistency with other SMP related APIs (e.g., "configNUMBER_OF_CORES").
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.