Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MISRA_C_2012 rule 7.2 violation #842

Merged
merged 8 commits into from
Dec 6, 2023

Conversation

kar-rahul-aws
Copy link
Member

@kar-rahul-aws kar-rahul-aws commented Oct 19, 2023

Fix MISRA C 2012 rule 7.2 violation

Description

MISRA C 2012 rule 7.2

A "u" or "U" suffix shall be applied to all integer constants that are represented in an unsigned type.

MISRA violation

MISRA enforces the use of the U or u suffix for unsigned integer constants.
The statement which leads to the violation
const uint32_t ulCheckValue = ( uint32_t ) 0xa5a5a5a5;

Test Steps

N/A.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (71d86f9) 93.77% compared to head (1f4b5a1) 93.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #842   +/-   ##
=======================================
  Coverage   93.77%   93.77%           
=======================================
  Files           6        6           
  Lines        3179     3179           
  Branches      885      885           
=======================================
  Hits         2981     2981           
  Misses         91       91           
  Partials      107      107           
Flag Coverage Δ
unittests 93.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

include/stack_macros.h Outdated Show resolved Hide resolved
@chinglee-iot chinglee-iot requested a review from a team as a code owner October 31, 2023 04:26
Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aggarg aggarg merged commit ce41f6e into FreeRTOS:main Dec 6, 2023
17 checks passed
@aggarg aggarg deleted the fix_misra_7_2 branch December 6, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants