Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reliability issues in CMake sample #835

Merged
merged 5 commits into from
Oct 17, 2023

Conversation

kar-rahul-aws
Copy link
Member

Description

This PR fixes reliability issues in Sonar Cloud tests, caused by unreachable code.

Test Steps

Re-run the Sonar cloud tests for reliability.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kar-rahul-aws kar-rahul-aws marked this pull request as draft October 16, 2023 18:08
@kar-rahul-aws kar-rahul-aws requested a review from n9wxu October 16, 2023 18:12
@kar-rahul-aws kar-rahul-aws marked this pull request as ready for review October 16, 2023 18:14
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (30283b5) 93.13% compared to head (15b807d) 93.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #835   +/-   ##
=======================================
  Coverage   93.13%   93.13%           
=======================================
  Files           6        6           
  Lines        2549     2549           
  Branches      608      608           
=======================================
  Hits         2374     2374           
  Misses        120      120           
  Partials       55       55           
Flag Coverage Δ
unittests 93.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kar-rahul-aws kar-rahul-aws merged commit 59ba98b into FreeRTOS:main Oct 17, 2023
@kar-rahul-aws kar-rahul-aws deleted the fix_sonar_cloud_issue branch October 17, 2023 16:51
n9wxu pushed a commit to n9wxu/FreeRTOS-Kernel that referenced this pull request Oct 26, 2023
* Fix reliability issues in CMake example sample.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants