Sample FreeRTOSConfig.h and template port #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #812 +/- ##
=======================================
Coverage 93.62% 93.62%
=======================================
Files 6 6
Lines 2508 2508
Branches 598 598
=======================================
Hits 2348 2348
Misses 107 107
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/bot run |
|
/bot run formatting |
|
/bot run formattin |
|
/bot run formatting |
|
/bot run formatting |
|
/bot run |
|
Kudos, SonarCloud Quality Gate passed!
|
archigup
reviewed
Sep 28, 2023
Comment on lines
+409
to
+424
| #define INCLUDE_vTaskPrioritySet 1 | ||
| #define INCLUDE_uxTaskPriorityGet 1 | ||
| #define INCLUDE_vTaskDelete 1 | ||
| #define INCLUDE_vTaskSuspend 1 | ||
| #define INCLUDE_xResumeFromISR 1 | ||
| #define INCLUDE_vTaskDelayUntil 1 | ||
| #define INCLUDE_vTaskDelay 1 | ||
| #define INCLUDE_xTaskGetSchedulerState 1 | ||
| #define INCLUDE_xTaskGetCurrentTaskHandle 1 | ||
| #define INCLUDE_uxTaskGetStackHighWaterMark 0 | ||
| #define INCLUDE_xTaskGetIdleTaskHandle 0 | ||
| #define INCLUDE_eTaskGetState 0 | ||
| #define INCLUDE_xEventGroupSetBitFromISR 1 | ||
| #define INCLUDE_xTimerPendFunctionCall 0 | ||
| #define INCLUDE_xTaskAbortDelay 0 | ||
| #define INCLUDE_xTaskGetHandle 0 |
There was a problem hiding this comment.
Suggested change
| #define INCLUDE_vTaskPrioritySet 1 | |
| #define INCLUDE_uxTaskPriorityGet 1 | |
| #define INCLUDE_vTaskDelete 1 | |
| #define INCLUDE_vTaskSuspend 1 | |
| #define INCLUDE_xResumeFromISR 1 | |
| #define INCLUDE_vTaskDelayUntil 1 | |
| #define INCLUDE_vTaskDelay 1 | |
| #define INCLUDE_xTaskGetSchedulerState 1 | |
| #define INCLUDE_xTaskGetCurrentTaskHandle 1 | |
| #define INCLUDE_uxTaskGetStackHighWaterMark 0 | |
| #define INCLUDE_xTaskGetIdleTaskHandle 0 | |
| #define INCLUDE_eTaskGetState 0 | |
| #define INCLUDE_xEventGroupSetBitFromISR 1 | |
| #define INCLUDE_xTimerPendFunctionCall 0 | |
| #define INCLUDE_xTaskAbortDelay 0 | |
| #define INCLUDE_xTaskGetHandle 0 | |
| #define INCLUDE_vTaskPrioritySet 1 | |
| #define INCLUDE_uxTaskPriorityGet 1 | |
| #define INCLUDE_vTaskDelete 1 | |
| #define INCLUDE_vTaskSuspend 1 | |
| #define INCLUDE_xResumeFromISR 1 | |
| #define INCLUDE_vTaskDelayUntil 1 | |
| #define INCLUDE_vTaskDelay 1 | |
| #define INCLUDE_xTaskGetSchedulerState 1 | |
| #define INCLUDE_xTaskGetCurrentTaskHandle 1 | |
| #define INCLUDE_uxTaskGetStackHighWaterMark 1 | |
| #define INCLUDE_xTaskGetIdleTaskHandle 1 | |
| #define INCLUDE_eTaskGetState 1 | |
| #define INCLUDE_xEventGroupSetBitFromISR 1 | |
| #define INCLUDE_xTimerPendFunctionCall 1 | |
| #define INCLUDE_xTaskAbortDelay 1 | |
| #define INCLUDE_xTaskGetHandle 1 |
Skptak
reviewed
Sep 29, 2023
| /* Set configGENERATE_RUN_TIME_STATS to 1 to have FreeRTOS collect data on the | ||
| * processing time used by each task. Set to 0 to not collect the data. The | ||
| * application writer needs to provide a clock source if set to 1. Defaults to 0 | ||
| * if left undefined. See https://www.freertos.org/rtos-run-time-stats.html */ |
There was a problem hiding this comment.
Is there a reason for two spaces after every period in these comments?
| /* Debugging assistance. ******************************************************/ | ||
| /******************************************************************************/ | ||
|
|
||
| /* configASSERT() has the same semantics as the standard C assert(). It can |
There was a problem hiding this comment.
Should these comments be starting with two * characters?
| * the application writer can provide functions that execute in privileged mode. | ||
| * See: https://www.freertos.org/a00110.html#configINCLUDE_APPLICATION_DEFINED_PRIVILEGED_FUNCTIONS | ||
| * Defaults to 0 if left undefined. Only used by the FreeRTOS Cortex-M MPU ports, | ||
| * not the standard ARMv7-M Cortex-M port. */ |
There was a problem hiding this comment.
I think it's in our coding style to place the end of a comment block on a separate line?
Skptak
approved these changes
Sep 29, 2023
AniruddhaKanhere
approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample FreeRTOSConfig.h and template port
Description
This change adds a FreeRTOSConfig.h with all features documented. This configuration does compile but is intended to be a starter file for your application and is not guaranteed to have the most appropriate settings for you. Additionally, this configuration of this file is not guaranteed to be stable over time.
Additionally, this push adds a "template" port called template. This port is intended to allow the kernel to compile but it will not create a functional RTOS. The purpose of this port is as follows:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.