Fix portSWITCH_TO_USER_MODE() on Armv7-M MPU ports #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ged task requests to be unprivileged
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #803 +/- ##
=======================================
Coverage 93.62% 93.62%
=======================================
Files 6 6
Lines 2508 2508
Branches 598 598
=======================================
Hits 2348 2348
Misses 107 107
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ded macros, remove the incorrect attribute comments
|
/bot run formatting |
Skptak
force-pushed
the
portSwitchToUserModeFix
branch
from
c6d3547 to
398e82b
Compare
jasonpcarroll
previously approved these changes
Sep 21, 2023
aggarg
changed the title
Signed-off-by: Gaurav Aggarwal <[email protected]>
Signed-off-by: Gaurav Aggarwal <[email protected]>
Signed-off-by: Gaurav Aggarwal <[email protected]>
aggarg
approved these changes
Sep 25, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
kar-rahul-aws
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A task's privilege level is stored in
ulTaskFlagmember in the TCB. Current implementation ofportSWITCH_TO_USER_MODE()does not update this flag but just lowers the processor's privilege level. This results in many APIs incorrectly determining task's privilege level and access permissions -This PR fixes the
portSWITCH_TO_USER_MODE()implementation to correctly update theulTaskFlagmember in the TCB before lowering the processor's privilege level.Test Steps
Tested on Cortex-M7.
Checklist:
Related Issue
NA.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.