Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate the task create function for core affinity #789

Merged
merged 10 commits into from
Oct 12, 2023

Conversation

chinglee-iot
Copy link
Member

@chinglee-iot chinglee-iot commented Sep 9, 2023

Separate the task create function for core affinity

Description

Create the following private function to create task:

  • prvCreateStaticTask
  • prvCreateRestrictedStaticTask
  • prvCreateRestrictedTask
  • prvCreateTask

uxCoreAffinityMask and prvAddNewTaskToReadyList are still required to be called to setup core affinity and add the task to ready list.

Test Steps

N/A

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

Address #750 in comment 1151, 1625

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@chinglee-iot chinglee-iot requested a review from a team as a code owner September 9, 2023 05:46
@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4bfb9b2) 93.64% compared to head (7c01f56) 93.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #789      +/-   ##
==========================================
+ Coverage   93.64%   93.66%   +0.02%     
==========================================
  Files           6        6              
  Lines        2517     2526       +9     
  Branches      602      604       +2     
==========================================
+ Hits         2357     2366       +9     
  Misses        107      107              
  Partials       53       53              
Flag Coverage Δ
unittests 93.66% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
tasks.c 94.92% <100.00%> (+0.05%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@chinglee-iot chinglee-iot merged commit 2be332a into FreeRTOS:main Oct 12, 2023
17 checks passed
@chinglee-iot chinglee-iot deleted the update-task-create branch October 19, 2023 06:37
laroche pushed a commit to laroche/FreeRTOS-Kernel that referenced this pull request Apr 18, 2024
* * Percepio Trace Recorder v4.6.0

* Add space between inclusion of header and comment

* Fix broken posix build - part 1

* Add percepio timer implementation

* Remove delted trace recorder header file

* Fix Networking demo  build

* Fix CLI demo

* Fix visual studio version number

* Fix core header check

* Fix more core checks

* Fix last of core checks

Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Alfred Gedeon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants