Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing FreeRTOS+ defines #642

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Add missing FreeRTOS+ defines #642

merged 1 commit into from
Mar 14, 2023

Conversation

HTRamsey
Copy link
Contributor

Add missing FreeRTOS+ defines

Description

These are currently defined in FreeRTOS-Plus-TCP until they are moved here.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@HTRamsey HTRamsey requested a review from a team as a code owner March 11, 2023 17:37
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (309a18a) 94.34% compared to head (9b260f2) 94.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #642   +/-   ##
=======================================
  Coverage   94.34%   94.34%           
=======================================
  Files           6        6           
  Lines        2368     2368           
  Branches      578      578           
=======================================
  Hits         2234     2234           
  Misses         85       85           
  Partials       49       49           
Flag Coverage Δ
unittests 94.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aggarg
Copy link
Member

aggarg commented Mar 13, 2023

These macros are not used in the kernel code and are only used in the FreeRTOS+TCP code. What is the motivation to move them to the kernel?

@HTRamsey
Copy link
Contributor Author

@aggarg That decision was apparently already made some time ago for the rest of the errno values

Copy link
Member

@AniruddhaKanhere AniruddhaKanhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @holden-zenith, thank you for this PR. I am approving this.

@paulbartell paulbartell merged commit 55658e1 into FreeRTOS:main Mar 14, 2023
@HTRamsey HTRamsey deleted the dev-defines branch March 14, 2023 22:50
This was linked to issues Mar 25, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

G M
5 participants