Regression Bug Fix: Fix Incorrect Return of MSVC-MingW portYIELD_FROM_ISR #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_ISR
There is a regression issue introduced in
FreeRTOS@cfc2688.
This PR was intended to update MIT licensed header from v9 to v10.
But it accidentally changed "portYIELD_FROM_ISR( x )" in MSVC-MingW/portmacro.h.
It caused "portYIELD_FROM_ISR( x )" does not return correct value to "prvProcessSimulatedInterrupts".
aggarg
approved these changes
Dec 16, 2024
|
t2-g
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a regression issue introduced in cfc2688.
That PR was intended to update MIT licensed header from v9 to v10.
But it accidentally changed "portYIELD_FROM_ISR( x )" in MSVC-MingW/portmacro.h.
It caused "portYIELD_FROM_ISR( x )" does not return correct value to "prvProcessSimulatedInterrupts".
Test Steps
"prvProcessSimulatedInterrupts" checks the return value of ISR (portYIELD_FROM_ISR( x )) and updates ulSwitchRequired.
I tested on my laptop. The current return value is 0x52 which is due to missing return value of portYIELD_FROM_ISR( x ).
After this patch, the returned value is correct.
Checklist:
Related Issue
FreeRTOS/FreeRTOS#1310
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.