Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifest to use 'V' #1201

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

kstribrnAmzn
Copy link
Member

@kstribrnAmzn kstribrnAmzn commented Nov 29, 2024

Description

Release tags use a capitalized V.
Our manifest tag is used by our SBOM
script to generate the URL and so
this needs to be capitalized to generate
a valid URL.

Test Steps

Testing the manifest updater...

./manifest_updater.py -v 12.34.56

manifest.yml contents

name : "FreeRTOS-Kernel"
version: "V12.34.56"
description: "FreeRTOS Kernel."
license: "MIT"

Verifying the SBOM generator...

export GITHUB_REPOSITORY=FreeRTOS/FreeRTOS-Kernel
python3 ./scan_dir.py --repo-root-path /Users/kstribrn/workspace/forks/FreeRTOS-Kernel
SPDXVersion: SPDX-2.2
DataLicense: CC0-1.0
SPDXID: SPDXRef-DOCUMENT
DocumentName: FreeRTOS-Kernel
DocumentNamespace: https://github.com/FreeRTOS/FreeRTOS-Kernel/blob/V11.1.0/sbom.spdx
Creator: Organization:Amazon Web Services
Created: 2024-11-29T10:04:23Z
CreatorComment: NOASSERTION
DocumentComment: NOASSERTION

PackageName: FreeRTOS-Kernel
SPDXID: SPDXRef-Package-FreeRTOS-Kernel
PackageVersion: V11.1.0
ExternalRef: SECURITY cpe23Type cpe:2.3:o:amazon:freertos:V11.1.0:*:*:*:*:*:*:*
PackageDownloadLocation: https://github.com/FreeRTOS/FreeRTOS-Kernel/tree/V11.1.0
PackageLicenseDeclared: MIT
PackageLicenseConcluded: MIT
PackageLicenseInfoFromFiles: NOASSERTION
FilesAnalyzed: true
PackageVerificationCode: da39a3ee5e6b4b0d3255bfef95601890afd80709
PackageCopyrightText: NOASSERTION
PackageSummary: NOASSERTION
PackageDescription: FreeRTOS Kernel.

The repo tag URL is valid.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • [N/A] I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

#1200

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Release tags use a capitalized V.
Our manifest tag is used by our SBOM
script to generate the URL and so
this needs to be capitalized to generate
a valid URL.
@kstribrnAmzn kstribrnAmzn requested a review from a team as a code owner November 29, 2024 17:52
Copy link

sonarcloud bot commented Nov 29, 2024

@kstribrnAmzn kstribrnAmzn merged commit 974351f into FreeRTOS:main Dec 2, 2024
16 checks passed
@kstribrnAmzn kstribrnAmzn deleted the fixManifestVersion branch December 2, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants