Fix SMP debugging issue on rp2040 #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to FreeRTOS#1172 Add `multicore_reset_core1` before `multicore_launch_core1` in `xPortStartScheduler` function to fix debugging issue on rp2040 with SMP enabled. * Modify `portable/ThirdParty/GCC/RP2040/port.c` to include a call to `multicore_reset_core1` before `multicore_launch_core1` within the `#if portRUNNING_ON_BOTH_CORES` block.
ActoryOu
reviewed
Nov 1, 2024
ActoryOu
reviewed
Nov 1, 2024
ActoryOu
approved these changes
Nov 1, 2024
kar-rahul-aws
approved these changes
Nov 1, 2024
|
This works. For future reference: My last comment in the issue, about the Timer issue this is related to. |
|
Reached out to Raspbery Pi to confirm that they are okay with the change. |
|
Hi @aggarg and team, Thanks for the update and for reaching out to Raspberry Pi for confirmation. Please let me know if any additional input or verification is needed from my end. I'll be happy to assist further. Thanks again for your support! |
|
kilograham
approved these changes
Nov 4, 2024
aggarg
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1172
Add
multicore_reset_core1beforemulticore_launch_core1inxPortStartSchedulerfunction to fix debugging issue on rp2040 with SMP enabled.portable/ThirdParty/GCC/RP2040/port.cto include a call tomulticore_reset_core1beforemulticore_launch_core1within the#if portRUNNING_ON_BOTH_CORESblock.