Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xtensa support updated and moved to Partner-Supported submodules #1156

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

ianstcdns
Copy link
Contributor

Remove legacy Xtensa port; leave README with pointer to latest partner-maintained code

Description

The Xtensa FreeRTOS port has been consolidated in the Partner-Supported submodules, along with numerous updates and bug-fixes.
The old location now contains a README indicating where to find the latest version of the Xtensa port and test code.

Test Steps

  • Tested via various demo and stress tests as provided through the Partner-Supported-Demos submodule.
  • Regression testing on many different LX7, LX8, and NX configurations.

Checklist:

  • [ x ] I have tested my changes. No regression in existing tests.
  • [ x ] I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

N/A

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ianstcdns
Copy link
Contributor Author

@aggarg @RichardBarry

Submitting updated Xtensa port to FreeRTOS v11

I've created pull requests for Cadence's updated Xtensa FreeRTOS port and demo code. As you recommended, we have moved it to the Partner-Supported-Ports and Partner-Supported-Demos submodules, removed out-of-date code from the higher-level repos, and left a couple of READMEs in the old locations indicating the new home for this code.

Thank you in advance for your help reviewing this upstream request.

@cookpate
Copy link
Member

FreeRTOS/FreeRTOS-Kernel-Partner-Supported-Ports#15 has been merged. Could you move the submodule pointer?

diff --git a/portable/ThirdParty/Partner-Supported-Ports b/portable/ThirdParty/Partner-Supported-Ports
index dc3afc6e8..abc22103e 160000
--- a/portable/ThirdParty/Partner-Supported-Ports
+++ b/portable/ThirdParty/Partner-Supported-Ports
@@ -1 +1 @@
-Subproject commit dc3afc6e837426b4bda81bbb6cf45bfb6f34c7e9
+Subproject commit abc22103e1e6634b33457d4127bff1ab62f27f90

@ianstcdns
Copy link
Contributor Author

Thank you for the quick review and merge. I've updated the Partner-Supported-Ports submodule pointer.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.27%. Comparing base (61440fc) to head (080ab2f).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1156      +/-   ##
==========================================
- Coverage   95.90%   92.27%   -3.63%     
==========================================
  Files           6        6              
  Lines        3225     3225              
  Branches      884      884              
==========================================
- Hits         3093     2976     -117     
  Misses        132      132              
- Partials        0      117     +117     
Flag Coverage Δ
unittests 92.27% <ø> (-3.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aggarg
Copy link
Member

aggarg commented Oct 15, 2024

@ianstcdns Please sync with the latest main branch.

Copy link

@ianstcdns
Copy link
Contributor Author

Thanks, @aggarg. Rebased on top of main. Is it best to squash the 2 commits or to leave them separate?

@rawalexe rawalexe merged commit 5f3bab1 into FreeRTOS:main Oct 15, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants