Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed macro __VFP_FP__ to __ARM_FP #1088

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Changed macro __VFP_FP__ to __ARM_FP #1088

merged 2 commits into from
Jun 11, 2024

Conversation

haydenridd
Copy link
Contributor

@haydenridd haydenridd commented Jun 10, 2024

Changed macro __VFP_FP__ to __ARM_FP

Description

Changed macro __VFP_FP__ to __ARM_FP for ports GCC/ARM_CM7, GCC/ARM_CM4_MPU, and GCC/ARM_CM4F to accurately reflect if floating point hardware support is enabled. See linked issue for more details, but the macro __VFP_FP__ is deprecated, and always set to 1 regardless of if floating point is enabled or not.

Test Steps

  • Compiling the affected ports without floating point support enabled (-mfloat-abi=soft) now properly throws a compiler error

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

Issue ID: 1087
#1087

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…_CM4_MPU, and GCC/ARM_CM4F to accurately reflect if floating point hardware support is enabled
@haydenridd haydenridd requested a review from a team as a code owner June 10, 2024 17:20
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@aggarg aggarg merged commit 28b6a14 into FreeRTOS:main Jun 11, 2024
15 checks passed
AhmedIsmail02 pushed a commit to AhmedIsmail02/FreeRTOS-Kernel that referenced this pull request Jun 12, 2024
…_CM4_MPU, and GCC/ARM_CM4F to accurately reflect if floating point hardware support is enabled (FreeRTOS#1088)

Co-authored-by: Hayden Riddiford <[email protected]>
Co-authored-by: Gaurav-Aggarwal-AWS <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants