Fix for mismatched op-types on line 3937 on tasks.c - Issue 1066 #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
aggarg
reviewed
May 24, 2024
| @@ -3935,6 +3935,9 @@ void vTaskSuspendAll( void ) | |||
| * processed. */ | |||
| xReturn = 0; | |||
| } | |||
| /* MISRA Ref 10.4.1 [Mismatched Operand Types] */ | |||
| /* More details at: https://github.com/FreeRTOS/FreeRTOS-Kernel/blob/main/MISRA.md#rule-104 */ | |||
| /* codesonar[misra_c_2012_rule_10_4_violation] */ | |||
There was a problem hiding this comment.
To keep it consistent with other suppression, can change it to the following:
coverity[misra_c_2012_rule_10_4_violation]
Edit - Ignore my comment. @kar-rahul-aws has raised a PR to address this issue.
|
Hi @markhermeling |
|
I validated that the warning is gone with these changes. |
|
Thanks for confirming @markhermeling . We will close this PR, since #1072 fixes the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for MISRA C 2012 Rule 10.4 violation: Mismatched operand types, see description in #1066
Description
No code changes, added a deviation in MISRA.md and comments into tasks.c
Test Steps
No code changes
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.