Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the change introduced in PR #1051 #1056

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

aggarg
Copy link
Member

@aggarg aggarg commented May 14, 2024

Description

As pointed out by Jeff Tenney, the comment introduced in the PR is not accurate.

Test Steps

I verified using the following code snippet:

void Task( void * param )
{
    SemaphoreHandle_t xBinarySem;

    ( void ) param;

    xBinarySem = xSemaphoreCreateBinary();

    xSemaphoreTake( xBinarySem, portMAX_DELAY );

    for( ;; )
    {
        HAL_GPIO_TogglePin( LD1_GPIO_Port, LD1_Pin );
        vTaskDelay( pdMS_TO_TICKS( 1000 ) );
    }
}

void app_main( void )
{
    xTaskCreate( Task,
                 "Task",
                 configMINIMAL_STACK_SIZE,
                 NULL,
                 tskIDLE_PRIORITY | portPRIVILEGE_BIT,
                 NULL );

    vTaskStartScheduler();

    for( ;; );
}

Checklist:

  • [NA] I have tested my changes. No regression in existing tests.
  • [NA] I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

As pointed out by Jeff Tenney, the comment introduced in the PR is not
accurate.

Signed-off-by: Gaurav Aggarwal <[email protected]>
@aggarg aggarg requested a review from a team as a code owner May 14, 2024 09:17
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@aggarg aggarg merged commit a8376db into FreeRTOS:main May 14, 2024
16 checks passed
@aggarg aggarg deleted the list_comment branch May 14, 2024 10:54
@ElectricRCAircraftGuy
Copy link
Contributor

ElectricRCAircraftGuy commented May 14, 2024

@aggarg , thank you for your support on this. I left a follow-up comment and questions here: https://github.com/FreeRTOS/FreeRTOS-Kernel/pull/1051/files#r1600607868

schilkp pushed a commit to schilkp/FreeRTOS-Kernel that referenced this pull request May 17, 2024
As pointed out by Jeff Tenney, the comment introduced in the PR is not
accurate.

Signed-off-by: Gaurav Aggarwal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants