Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM CM0+ MPU Port #1005

Merged
merged 3 commits into from
Mar 26, 2024
Merged

ARM CM0+ MPU Port #1005

merged 3 commits into from
Mar 26, 2024

Conversation

Skptak
Copy link
Member

@Skptak Skptak commented Mar 1, 2024

Description

This pull request creates an ARM Cortex M0 Plus MPU Enabled Port
These changes have been overlayed onto the ARM_CM23_NTZ/non_secure port to create a minimal diff for the review
When the changes have been reviewed and approved this will then be moved into a separate directory.

Test Steps

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Skptak Skptak requested a review from a team as a code owner March 1, 2024 19:21
@Skptak Skptak self-assigned this Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.00%. Comparing base (625b24a) to head (c05069a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1005   +/-   ##
=======================================
  Coverage   93.00%   93.00%           
=======================================
  Files           6        6           
  Lines        3200     3200           
  Branches      879      879           
=======================================
  Hits         2976     2976           
  Misses        111      111           
  Partials      113      113           
Flag Coverage Δ
unittests 93.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Skptak Skptak force-pushed the ARM_CM23_For_CM0 branch 3 times, most recently from cdbccf3 to 7ba1e3e Compare March 1, 2024 21:38
portable/GCC/ARM_CM23_NTZ/non_secure/port.c Outdated Show resolved Hide resolved
portable/GCC/ARM_CM23_NTZ/non_secure/port.c Outdated Show resolved Hide resolved
portable/GCC/ARM_CM23_NTZ/non_secure/portmacrocommon.h Outdated Show resolved Hide resolved
#define portMPU_REGION_CACHEABLE_BUFFERABLE ( 0x7UL << 16UL )

#define portMPU_REGION_VALID ( 0x10UL )
#define portMPU_RASR_TEX_S_C_B_MASK ( 0x3FUL )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 0x7 which is then shifted by 16 bits?

portable/GCC/ARM_CM23_NTZ/non_secure/portasm.c Outdated Show resolved Hide resolved
@Skptak Skptak force-pushed the ARM_CM23_For_CM0 branch from 78b8d2a to 23363bc Compare March 21, 2024 01:15
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@joshzarr joshzarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified I was able to compile the port and run using the M0+ demo application.
Deferring a full review to Gaurav who has already approved this PR

@Skptak Skptak merged commit 345a86d into FreeRTOS:main Mar 26, 2024
18 checks passed
@Skptak Skptak deleted the ARM_CM23_For_CM0 branch April 2, 2024 01:14
laroche pushed a commit to laroche/FreeRTOS-Kernel that referenced this pull request Apr 18, 2024
The number of implemented priority bits for Armv8-M baseline
implementation is defined by the architecture as 2. Therefore the
config option `configPRIO_BITS` is updated to 2.

In addition, in Armv8-M baseline implementation BASEPRI is RES0.
Therefore, `configMAX_SYSCALL_INTERRUPT_PRIORITY` is not supported. Hence
this config option is removed.

Signed-off-by: Devaraj Ranganna <[email protected]>
Co-authored-by: Gaurav-Aggarwal-AWS <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants