Add sara r4 compile warning check #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chinglee-iot
commented
Nov 4, 2021
•
chinglee-iot
commented
- Fix SARA R4 cellular module compile warning to comply with C90
* Add guards for C++ linkage
* Fix sara_r4 compile warning * Add sara_r4 CI compile warning check
Closed
andysun2015
reviewed
Nov 5, 2021
andysun2015
reviewed
Nov 5, 2021
andysun2015
reviewed
Nov 5, 2021
modules/sara_r4/cellular_r4.c
Outdated
| @@ -490,11 +492,58 @@ uint32_t _Cellular_GetSocketId( CellularContext_t * pContext, | |||
| cellularStatus = CELLULAR_BAD_PARAMETER; | |||
| } | |||
|
|
|||
| if( ( cellularStatus == CELLULAR_SUCCESS ) && | |||
| ( sessionId >= MIN_TCP_SESSION_ID ) && ( sessionId <= MAX_TCP_SESSION_ID ) ) | |||
| if( ( cellularStatus == CELLULAR_SUCCESS ) && ( sessionId <= MAX_TCP_SESSION_ID ) ) | |||
There was a problem hiding this comment.
The condition ( sessionId >= MIN_TCP_SESSION_ID ) can't be ignored.
There was a problem hiding this comment.
#define MIN_TCP_SESSION_ID ( 0U )
uint32_t _Cellular_GetSocketId( CellularContext_t * pContext,
uint8_t sessionId )
uint8_t is always >= 0
There was a problem hiding this comment.
But now I see #define MIN_TCP_SESSION_ID ( 0 ) instead of #define MIN_TCP_SESSION_ID ( 0U )
One of them need to be corrected.
There was a problem hiding this comment.
Sorry for typo, you are right.
#define MIN_TCP_SESSION_ID ( 0 )
./cellular_r4_api.c:451: if( ( tempValue >= MIN_TCP_SESSION_ID ) && ( tempValue <= MAX_TCP_SESSION_ID ) )
./cellular_r4_urc_handler.c:395: if( ( tempValue >= MIN_TCP_SESSION_ID ) && ( tempValue <= MAX_TCP_SESSION_ID ) )
./cellular_r4_urc_handler.c:490: if( ( tempValue >= MIN_TCP_SESSION_ID ) && ( tempValue <= MAX_TCP_SESSION_ID ) )
./cellular_r4_urc_handler.c:554: if( ( tempValue >= MIN_TCP_SESSION_ID ) && ( tempValue <= MAX_TCP_SESSION_ID ) )
The usage here is to compare int32_t ( result of Cellular_ATStrtoi ).
Please suggest the modification.
There was a problem hiding this comment.
Original warning message.
[ 19%] Built target cmock
/mnt/c/msys64/home/chinglee/cellular/public/chinglee/FreeRTOS-Cellular-Interface/modules/sara_r4/cellular_r4.c: In function ‘_Cellular_GetSocketId’:
/mnt/c/msys64/home/chinglee/cellular/public/chinglee/FreeRTOS-Cellular-Interface/modules/sara_r4/cellular_r4.c:496:21: warning: comparison is always true due to limited range of data type [-Wtype-limits]
496 | ( sessionId >= MIN_TCP_SESSION_ID ) && ( sessionId <= MAX_TCP_SESSION_ID ) ) {
|
There was a problem hiding this comment.
Update the type comparison MAX_TCP_SESSION_ID in next commit.
andysun2015
reviewed
Nov 7, 2021
andysun2015
reviewed
Nov 7, 2021
andysun2015
reviewed
Nov 7, 2021
andysun2015
reviewed
Nov 7, 2021
n9wxu
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.