[Cellular Library] Fix build warning message. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinglee-iot
previously approved these changes
Sep 1, 2021
cobusve
reviewed
Sep 2, 2021
cobusve
reviewed
Sep 2, 2021
| @@ -1679,7 +1676,7 @@ void test__Cellular_PktioSendAtCmd_Invalid_String( void ) | |||
| CellularPktStatus_t pktStatus = CELLULAR_PKT_STATUS_OK; | |||
| CellularContext_t context; | |||
| CellularCommInterface_t * pCommIntf = &CellularCommInterface; | |||
| CellularCommInterfaceHandle_t commInterfaceHandle; | |||
| CellularCommInterfaceHandle_t commInterfaceHandle = ( CellularCommInterfaceHandle_t ) malloc( sizeof( CellularCommInterfaceHandle_t ) ); | |||
There was a problem hiding this comment.
please refer to this change.
cobusve
reviewed
Sep 2, 2021
cobusve
reviewed
Sep 2, 2021
cobusve
reviewed
Sep 2, 2021
cobusve
reviewed
Sep 2, 2021
| @@ -903,11 +903,10 @@ void test_Cellular_ATStrtoi_Happy_Path( void ) | |||
| { | |||
| CellularATError_t cellularStatus = CELLULAR_AT_SUCCESS; | |||
| char * pStr = malloc( sizeof( char ) * ( strlen( CELLULAR_SAMPLE_STRTOL_HAPPY_CASE_STRING ) + 1 ) ); | |||
There was a problem hiding this comment.
please refer to this change.
cobusve
reviewed
Sep 2, 2021
cobusve
reviewed
Sep 2, 2021
cobusve
reviewed
Sep 3, 2021
common/src/cellular_pktio.c
Outdated
| @@ -676,7 +676,7 @@ static CellularPktStatus_t _handleMsgType( CellularContext_t * pContext, | |||
| if( *ppAtResp == NULL ) | |||
| { | |||
| *ppAtResp = _Cellular_AtResponseNew(); | |||
| LogDebug( ( "Allocat at response %p", *ppAtResp ) ); | |||
| LogDebug( ( "Allocat at response %p", ( void * ) *ppAtResp ) ); | |||
There was a problem hiding this comment.
Thanks for the correction.
There was a problem hiding this comment.
Please refer to this change for the correction.
cobusve
approved these changes
Sep 4, 2021
chinglee-iot
approved these changes
Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.