Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing CREG/CGREG/CEREG separately. #182

Merged
merged 7 commits into from
Nov 20, 2024

Conversation

ActoryOu
Copy link
Member

@ActoryOu ActoryOu commented Nov 19, 2024

Parsing CREG/CGREG/CEREG separately.

Description

Like FreeRTOS forum post mentioned, the cellular interface doesn't handle CGREG RAC correctly. To parse all these reg status better, this PR separates the parsing flow into different functions.

  • Separate register status parsing for CREG/CGREG/CEREG.
  • Early break if any parsing error happens.
  • Adjust UT cases with the change.

Test Steps

  1. UT
    1. Create UT new test cases
    2. Execute UT
    3. Achieve 100% coverage
  2. Real target test from forum customer.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

chinglee-iot
chinglee-iot previously approved these changes Nov 19, 2024
source/cellular_3gpp_urc_handler.c Outdated Show resolved Hide resolved
source/cellular_3gpp_urc_handler.c Outdated Show resolved Hide resolved
source/cellular_3gpp_urc_handler.c Outdated Show resolved Hide resolved
@ActoryOu ActoryOu merged commit c2ed628 into FreeRTOS:main Nov 20, 2024
10 checks passed
@ActoryOu ActoryOu deleted the parsingRegStatus branch November 20, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants