Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set to numeric format in atcmdUpdateMccMnc #161

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Set to numeric format in atcmdUpdateMccMnc #161

merged 3 commits into from
Jan 2, 2024

Conversation

chinglee-iot
Copy link
Member

@chinglee-iot chinglee-iot commented Dec 26, 2023 •
edited
Loading

Set to numeric format in atcmdUpdateMccMnc

Description

  • In order not to rely on port initialization. Set to numeric format to acquire MCC and MNC information in atcmdUpdateMccMnc.

Test Steps

Remove the port initialize AT command "AT+COPS=3,2". The MCC and MNC can't be acquired with Cellular_CommonGetRegisteredNetwork correctly.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@chinglee-iot chinglee-iot mentioned this pull request Dec 26, 2023
Closed
ActoryOu
ActoryOu approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@ActoryOu ActoryOu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor question. Could you help to elaborate what happens in what platform if we don't limit it to numeric format?

@chinglee-iot chinglee-iot merged commit 9b939eb into FreeRTOS:main Jan 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kar-rahul-aws kar-rahul-aws kar-rahul-aws approved these changes

@ActoryOu ActoryOu ActoryOu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chinglee-iot @ActoryOu @kar-rahul-aws