Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _getMsgType for URC without prefix #159

Merged
merged 7 commits into from
Nov 22, 2023

Conversation

chinglee-iot
Copy link
Member

@chinglee-iot chinglee-iot commented Nov 21, 2023

Description

Update _getMsgType function for feedback from forum in this post.

  • Update the logic for port not using URC without prefix table
  • Check AT command type for response without prefix

Test Steps

N/A

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

* Update the logic for port not using URC without prefix table
* Check AT command type for response without prefix
Copy link
Member

@ActoryOu ActoryOu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the forum link on PR?

@chinglee-iot
Copy link
Member Author

Could you update the forum link on PR?

Updated in the description.

@chinglee-iot chinglee-iot merged commit 3309ce9 into FreeRTOS:main Nov 22, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants