Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CELLULAR_AT_MAX_STRING_SIZE configurable #140

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Make CELLULAR_AT_MAX_STRING_SIZE configurable #140

merged 2 commits into from
Jul 4, 2023

Conversation

ActoryOu
Copy link
Member

@ActoryOu ActoryOu commented Jul 3, 2023 •
edited
Loading

Make CELLULAR_AT_MAX_STRING_SIZE configurable

Description

  • Move CELLULAR_AT_MAX_STRING_SIZE to cellular_config_defaults.h.
  • Remove useless MACRO CELLULAR_AT_MAX_PREFIX_SIZE.

Test Steps

  • Compile project in FreeRTOS successfully.
  • Pass demo with BG96.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@chinglee-iot chinglee-iot self-requested a review July 3, 2023 08:14
@ActoryOu ActoryOu merged commit bfe3f48 into FreeRTOS:main Jul 4, 2023
@ActoryOu ActoryOu deleted the ConfigurableATLength branch July 4, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chinglee-iot chinglee-iot chinglee-iot approved these changes

@shubnil shubnil shubnil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ActoryOu @chinglee-iot @shubnil