Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AT command with no success result code #138

Merged
merged 8 commits into from
Jun 13, 2023

Conversation

chinglee-iot
Copy link
Member

@chinglee-iot chinglee-iot commented May 23, 2023

This PR adds no success result code command to support the issue #128.

Some cellular modem has command that doesn't reply success result code like "OK" to indicate status.
In the example, SIM8000C has AT+CIFSR command that only returns IP address.

AT+CIFSR
100.83.218.17   // Only IP address is returned in the response. No success result code.

Error result code is still returned by the modem.

AT+CIFSR
ERROR // Error result code is returned by modem

This PR add two new AT command types CELLULAR_AT_WO_PREFIX_NO_RESULT_CODE and CELLULAR_AT_WITH_PREFIX_NO_RESULT_CODE to support this kind of cellular modem. If response is received, this command is regarded as success the response callback will be called. No success result code is required.

Description

  • Add CELLULAR_AT_WO_PREFIX_NO_RESULT_CODE AT command type.
  • Add CELLULAR_AT_WITH_PREFIX_NO_RESULT_CODE AT command type.

Test Steps

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@chinglee-iot chinglee-iot changed the title Add no result code command Support AT command with no success result code May 23, 2023
@chinglee-iot chinglee-iot requested a review from ActoryOu May 23, 2023 12:37
@chinglee-iot chinglee-iot merged commit 4bc022e into FreeRTOS:main Jun 13, 2023
@chinglee-iot chinglee-iot deleted the dev-no-result-code-cmd branch June 13, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants