-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CELLULAR_CHECK_IS_PREFIX_LEADING_CHAR config #117
Merged
AniruddhaKanhere
merged 41 commits into
FreeRTOS:main
from
chinglee-iot:update-leading-char
Nov 8, 2022
Merged
Add CELLULAR_CHECK_IS_PREFIX_LEADING_CHAR config #117
AniruddhaKanhere
merged 41 commits into
FreeRTOS:main
from
chinglee-iot:update-leading-char
Nov 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Differnt modem may use different leading char for prefix string. Add config CELLULAR_CHECK_IS_PREFIX_LEADING_CHAR to support. * Use Cellular_ATIsPrefixPresent to check URC with prefix in pkthandler
ActoryOu
reviewed
Nov 4, 2022
* include CELLULAR_CHECK_IS_PREFIX_LEADING_CHAR in CELLULAR_CHECK_IS_PREFIX_CHAR
ActoryOu
approved these changes
Nov 4, 2022
AniruddhaKanhere
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CELLULAR_CHECK_IS_PREFIX_LEADING_CHAR config
With this PR, cellular interface can be customized to handle the following URC strings:
This string contains prefix char " " which is not default valid prefix char. User of cellular interface can define CELLULAR_CHECK_IS_PREFIX_CHAR in cellular_config.h to support prefix char " ".
This string contains leading char "^" which is not default leading char. User of cellular interface can define CELLULAR_CHECK_IS_PREFIX_LEADING_CHAR and CELLULAR_CHECK_IS_PREFIX_CHAR in cellular_config.h to support leading char "^".
This string is regarded as URC without prefix since there is no delimeter ":". To handle this URC string, user should add a item in URC handler table with pStrValue point to "^SYSSTART".