Handle undefined message when sending AT command #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ActoryOu
previously approved these changes
Oct 3, 2022
* ATE0 is the first AT command sent may still contains echo. Change the comand type to without response
ActoryOu
reviewed
Oct 5, 2022
ActoryOu
reviewed
Oct 5, 2022
ActoryOu
approved these changes
Oct 5, 2022
|
Please help to move modules change to below links: Thanks. |
shubnil
approved these changes
Oct 6, 2022
This was referenced Oct 6, 2022
ActoryOu
pushed a commit
to ActoryOu/FreeRTOS-Cellular-Interface
that referenced
this pull request
Oct 7, 2022
* Update pktio to handle undefined message when sending AT command * Undefined message handler is moved to pkthandler * Use PktRespMutex in pktio thread to keep data consistency * Add test cases to cover the undefined message handle flow * Update ATE0 handling in SARA R4 and HL7802. ATE0 may still echo back ATE0. Change the AT command type to CELLULAR_AT_WO_PREFIX
ActoryOu
added a commit
that referenced
this pull request
Oct 12, 2022
* Update cellular library to MIT license * Remove modules in cellular interface repo. * Update README. * Provide modules' repositories for reference implementations. * Update doxygen files. * Update HL7802 link in README. * Fix spelling. * Align introduction. * Remove Lab- prefix at url links * Update README. * Create Community-Supported-Ports Merged conflict. * Handle undefined message when sending AT command (#110) * Update pktio to handle undefined message when sending AT command * Undefined message handler is moved to pkthandler * Use PktRespMutex in pktio thread to keep data consistency * Add test cases to cover the undefined message handle flow * Update ATE0 handling in SARA R4 and HL7802. ATE0 may still echo back ATE0. Change the AT command type to CELLULAR_AT_WO_PREFIX * Reset the AT command type before calling callback (#113) * Reset the AT command type before calling pkthandler callback * Remove thirdparty folder. * Remove modules folder. * Update README doc for integrating library with cellular modems. * Remove Transport interface part in README. * Convert PNG to SVG. Co-authored-by: Ching-Hsin Lee <[email protected]> Co-authored-by: chinglee-iot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the issue feedback in FreeRTOS forum.