-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coverage-Cop Action Changes #71
Conversation
exit $RESULT | ||
|
||
- name: Upload Failed Codecov HTML Report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not upload the report even when it doesn't fail? This will reduce even further friction for developers and encourage them to squeeze out every possible test scenario possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default most repos require 100% line and branch coverage
Where felt un-neccessary to publish it every time?
But can easily do this by default if we want
with: | ||
repository: FreeRTOS/coreMQTT | ||
repository: skptak/coreMQTT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason we are adding a private repo here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were a couple actions that required changes to the repos, as such I needed to point to my fork in order to test the new actions. When the PRs for individual repos goes through a cleanup PR will go out that fixes all of these.
Splitting up #68 into more manageable single PRs containing just the changes to the individual actions
Will not be doing the YML files one by one, so please reference the #68 actions for proof of working
Relevant Coverage-Cop passing test can be found here