Fix issues in coverage-cop action #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanjos-dev
previously approved these changes
Feb 15, 2021
aggarw13
force-pushed
the
fix/coverage-cop-action
branch
from
f301f63 to
cfa83e4
Compare
yanjos-dev
approved these changes
Feb 15, 2021
gkwicker
approved these changes
Feb 15, 2021
| @@ -93,8 +93,8 @@ jobs: | |||
| uses: ./coverage-cop | |||
| with: | |||
| path: ./build/coverage.info | |||
| branch-min-coverage: 100 | |||
| line-min-coverage: 99 | |||
| branch-coverage-min: 70 | |||
There was a problem hiding this comment.
No specific reason for choosing 70. Any value is works as long as the test job for the action uses different values for the line and branch coverages to ensure to make it visible in logs that the action is correctly using the input parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes typos in the branch coverage checking logic of the coverage-cop action. Also, it renames the input parameters to be readable.