Removed survey to clean up the code - API CHANGE #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If nobody complains I'm willing to merge this |
|
I forgot to mention that this remove the webkitgtk dependency, making the remmina package lighter. @weberhofer @nastasi I need your go to proceed, in order to avoid packaging issues. |
|
I'll remove the dependencies as soon as you have committed. Thank you for notification! |
|
I'm waiting the PR of Giovanni concerning the freerdp update. |
|
I create a "-debian" repository branch compainion to remove the dependency mentioned above. |
|
@antenore: merge this ASAP. Later, this night, I will PR & merge libfreerdp_updates, and then notify major maintainers. |
|
Cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove completely the survey and the code used by the survey.
@muflone careful, this PR will change a little bit the API, if you need support let me now.
https://github.com/FreeRDP/Remmina/compare/nosurvey?expand=1#diff-eeaf206ca59e1445d97e45c0a14f68f3