Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable app name and locations #1046

Merged
merged 2 commits into from
Nov 12, 2016
Merged

Conversation

3v1n0
Copy link
Contributor

@3v1n0 3v1n0 commented Nov 7, 2016

Allow to customize data locations and app name at compile time.

This allows better snappification of Remmina (and potentially the ability of distribuiting multiple versions togeter, using different app names depending on channels, such as org.Remmina and org.Remmina.Unstable).
See https://github.com/3v1n0/Remmina-snap.

@giox069
Copy link
Contributor

giox069 commented Nov 8, 2016

Tested on ubuntu 16.04 in a development environment, seems to be fine.

@antenore
Copy link
Member

Tested on Ubuntu 16.04 as well, plus FreeBSD and Fedora 23/24 for compatibility reasons.

Everything is fine. For me can be merged.

@giox069 giox069 merged commit f640665 into FreeRDP:next Nov 12, 2016
@3v1n0
Copy link
Contributor Author

3v1n0 commented Nov 12, 2016

Thanks @antenore and @giox069, Snap branch (https://github.com/3v1n0/Remmina-snap) updated... Once you want to take ownership for it, just let me know. Also you might want to register the 'remmina' name in the ubuntu store (you can use snapcraft tool or the apps portal).

@giox069
Copy link
Contributor

giox069 commented Nov 12, 2016

Thank you again @3v1n0 , we will proceed as soon as we can.

@3v1n0
Copy link
Contributor Author

3v1n0 commented Nov 13, 2016

@giox069 no problem...

Let me know in case you'd need help for setting up travis jobs (if you don't want to use launchpad for this) to do automatic uploads on each commit to the edge channel and release tags to the stable one (an example is at https://github.com/elopio/hashicorp-snaps)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants