Skip to content
This repository has been archived by the owner on Apr 21, 2022. It is now read-only.

tsconfig.json [compilerOptions.target] should be "es2019", but found "5". #88

Closed
Jack-Works opened this issue Sep 13, 2019 · 4 comments
Closed

tsconfig.json [compilerOptions.target] should be "es2019", but found "5". #88

Jack-Works opened this issue Sep 13, 2019 · 4 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Jack-Works
Copy link
Contributor

"5" is ts.ScriptTarget.ES2018, pikapkg should transform back the enum value to "ES2018"
@aeisenberg
Copy link

Bump...I'm getting the same error, but with different versions:

tsconfig.json [compilerOptions.target] should be "es2019", but found "8". You may encounter problems building.

@FredKSchott FredKSchott added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 21, 2019
@FredKSchott
Copy link
Owner

+1, this should be an easy one if anyone wants to help tackle

@yumauri yumauri mentioned this issue Oct 22, 2019
Merged
@yumauri
Copy link
Contributor

yumauri commented Oct 22, 2019

Made PR #95 for that

» tsconfig.json [compilerOptions.target] should be "es2019", but found "es2015". You may encounter problems building.
» tsconfig.json [compilerOptions.module] should be "esnext", but found "commonjs". You may encounter problems building.

FredKSchott added a commit that referenced this issue Oct 22, 2019
@FredKSchott
Merge pull request #95 from yumauri/master
5f426ef 
Fix issue #88
@FredKSchott
Copy link
Owner

you're awesome

Thanks @yumauri! Just merged, will do a release later today to get this out

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@aeisenberg @FredKSchott @Jack-Works @yumauri