Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pqdb-frontend] Framework for adding different views + Readme #75

Merged
merged 6 commits into from
May 27, 2020

Conversation

benj-zen
Copy link
Collaborator

No description provided.

@benj-zen benj-zen requested a review from a team as a code owner May 22, 2020 12:36
yarn start
```

This starts the React app and loads the url in the browser.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little SQL example would be convenient. Especially because the table overview is a little overwhelming at first

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the framework for the frontend views, so SQL examples will come soon, when views are created.

@benj-zen benj-zen requested a review from taudor May 27, 2020 08:51
Copy link
Collaborator

@taudor taudor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@dingens
Copy link
Contributor

dingens commented May 27, 2020

Until I've found out how to fix this WiseLibs/better-sqlite3#403 I can just do static code review :)

I'd suggest mv pqdb-frontend frontend. That's it ;)

@taudor taudor merged commit 531493c into master May 27, 2020
@taudor taudor deleted the frontent_views branch May 27, 2020 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants