Skip to content

1.7.5 (#78)

1.7.5 (#78) #93

GitHub Actions / Qodana for .NET completed Jan 11, 2025 in 0s

9293 new problems found by Qodana for .NET

Qodana for .NET

9293 new problems were found

Inspection name Severity Problems
Check .NET source code coverage 🔶 Warning 970
Redundant member initializer 🔶 Warning 46
Empty element content 🔶 Warning 42
Method return value is never used (private accessibility) 🔶 Warning 34
Redundant cast 🔶 Warning 31
Redundant name qualifier 🔶 Warning 26
Unresolved binding path when DataContext is known 🔶 Warning 23
Assignment is not used 🔶 Warning 22
Possible 'null' assignment to non-nullable entity 🔶 Warning 13
Redundant class or interface specification in base types list 🔶 Warning 13
Unused local variable 🔶 Warning 13
Possible 'System.InvalidOperationException' 🔶 Warning 10
Type member is never used (private accessibility) 🔶 Warning 10
Redundant namespace alias 🔶 Warning 10
Function never returns 🔶 Warning 7
Access to a static member of a type via a derived type 🔶 Warning 6
Unknown property 🔶 Warning 6
Redundant explicit type in array creation 🔶 Warning 6
Redundant resource 🔶 Warning 6
Invalid XML documentation comment 🔶 Warning 5
Overridden property 🔶 Warning 4
Overriding property 🔶 Warning 4
Redundant control flow jump statement 🔶 Warning 4
Possible 'System.NullReferenceException' 🔶 Warning 3
Auto-property accessor is never used (non-private accessibility) 🔶 Warning 3
Remove redundant attached property setter 🔶 Warning 3
Namespace does not correspond to file location 🔶 Warning 2
Non-ASCII characters 🔶 Warning 2
Private field can be converted into local variable 🔶 Warning 2
Redundant operand in logical conditional expression 🔶 Warning 2
Unused parameter (private accessibility) 🔶 Warning 2
Collection content is never queried (non-private accessibility) 🔶 Warning 1
Expression is always 'true' or always 'false' 🔶 Warning 1
Empty constructor 🔶 Warning 1
Empty statement is redundant 🔶 Warning 1
Expression is always 'null' 🔶 Warning 1
Return value of [MustUseReturnValue] annotated method is not used 🔶 Warning 1
Non-accessed field (private accessibility) 🔶 Warning 1
Non-accessed local variable 🔶 Warning 1
Redundant lambda expression parameter type specification 🔶 Warning 1
Redundant 'object.ToString()' call 🔶 Warning 1
Redundant using directive 🔶 Warning 1
Grid element column/row index is out of grid definition range 🔶 Warning 1
Missing grid column/row setter for non-first child 🔶 Warning 1
Validation by JSON Schema 🔶 Warning 1
Type member is never used (non-private accessibility) ◽️ Notice 4297
Redundant empty argument list on object creation expression ◽️ Notice 2729
Use preferred 'var' style (for built-in types) ◽️ Notice 112
Invert 'if' statement to reduce nesting ◽️ Notice 105
Member can be made private (non-private accessibility) ◽️ Notice 97
Use preferred style for trailing comma before new line in multiline lists ◽️ Notice 88
Type is never used (non-private accessibility) ◽️ Notice 58
Some values of the enum are not processed inside 'switch' statement and are handled via default section ◽️ Notice 47
Auto-property can be made get-only (non-private accessibility) ◽️ Notice 33
Remove redundant parentheses ◽️ Notice 29
Use preferred 'var' style (when type is simple) ◽️ Notice 29
Convert local variable or field into constant (private accessibility) ◽️ Notice 27
'if-return' statement can be rewritten as 'return' statement ◽️ Notice 25
Redundant 'else' keyword ◽️ Notice 21
Use object or collection initializer when possible ◽️ Notice 19
Field can be made readonly (non-private accessibility) ◽️ Notice 16
Redundant lambda signature parentheses ◽️ Notice 16
Part of foreach loop can be converted into LINQ-expression but another 'GetEnumerator' method will be used ◽️ Notice 14
Field can be made readonly (private accessibility) ◽️ Notice 12
Redundant string interpolation ◽️ Notice 11
Unused parameter (non-private accessibility) ◽️ Notice 10
Replace built-in type reference with a CLR type name or a keyword ◽️ Notice 9
RoslynAnalyzers Assertion condition is always true ◽️ Notice 8
Method return value is never used (non-private accessibility) ◽️ Notice 8
Convert lambda expression into method group ◽️ Notice 7
Loop can be converted into LINQ-expression ◽️ Notice 7
Non-accessed field (non-private accessibility) ◽️ Notice 7
Class with virtual (overridable) members never inherited (non-private accessibility) ◽️ Notice 6
Convert 'if' statement into 'switch' ◽️ Notice 6
Event is never subscribed to (non-private accessibility) ◽️ Notice 6
Use preferred style of 'new' expression when created type is evident ◽️ Notice 5
'if' statement can be rewritten as '?:' expression ◽️ Notice 5
Member can be made static (shared) (private accessibility) ◽️ Notice 5
Member can be made protected (non-private accessibility) ◽️ Notice 5
Use explicit or implicit modifier definition for type members ◽️ Notice 4
Auto-property can be made get-only (private accessibility) ◽️ Notice 4
Merge sequential checks into single conditional access check ◽️ Notice 4
Array creation can be replaced with array initializer ◽️ Notice 4
Some values of the enum are not processed inside 'switch' statement ◽️ Notice 4
Replace built-in type reference with a CLR type name or a keyword in static member access expressions ◽️ Notice 3
Class is never instantiated (non-private accessibility) ◽️ Notice 3
Foreach loop can be converted into LINQ-expression but another 'GetEnumerator' method will be used ◽️ Notice 3
Specify string comparison explicitly ◽️ Notice 3
Use preferred 'var' style (elsewhere) ◽️ Notice 3
Dictionary lookup can be simplified with 'TryGetValue' ◽️ Notice 2
Use compound assignment ◽️ Notice 2
Convert into lambda expression ◽️ Notice 2
Overlapping sections ◽️ Notice 2
RoslynAnalyzers Assertion arguments should be passed in the correct order ◽️ Notice 2
RoslynAnalyzers Use proper 'Assert' methods ◽️ Notice 2
Put local function after 'return' or 'continue' ◽️ Notice 2
Redundant semicolon after type or namespace declaration ◽️ Notice 2
Redundant verbatim string prefix ◽️ Notice 2
Local variable has too wide declaration scope ◽️ Notice 2
Use alias ◽️ Notice 2
Virtual (overridable) member is never overridden (non-private accessibility) ◽️ Notice 2
Use preferred style of default value expression when type is not evident ◽️ Notice 1
Adjust modifiers declaration order ◽️ Notice 1
RoslynAnalyzers Mark members as static ◽️ Notice 1
Empty region ◽️ Notice 1
RoslynAnalyzers Test class should have test method ◽️ Notice 1
Simplify LINQ expression (use 'All') ◽️ Notice 1
Use format specifier in interpolated strings ◽️ Notice 1
Type member is never accessed via base type (non-private accessibility) ◽️ Notice 1
Use 'Array.Empty<T>()' ◽️ Notice 1
Use collection's count property ◽️ Notice 1
Replace if statement with null-propagating code ◽️ Notice 1
@@ Code coverage @@
- 23% total lines covered
8210 lines analyzed, 1950 lines covered
# Calculated according to the filters of your coverage tool

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 4 dependencies

Third-party software list

This page lists the third-party software dependencies used in SoulSplitter

Dependency Version Licenses
MaterialDesignColors 2.1.4 MIT
MaterialDesignThemes 4.9.0 MIT
Microsoft.CSharp 4.7.0 MIT
Microsoft.Xaml.Behaviors.Wpf 1.1.39 MIT
Contact Qodana team

Contact us at [email protected]

Details

This result was published with Qodana GitHub Action

Annotations

Check warning on line 217 in src/SoulSplitter/Migrations/Migrator.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to a static member of a type via a derived type

Access to a static member of a type via a derived type

Check warning on line 231 in src/SoulSplitter/Migrations/Migrator.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to a static member of a type via a derived type

Access to a static member of a type via a derived type

Check warning on line 91 in src/SoulSplitter/Migrations/Migrator.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to a static member of a type via a derived type

Access to a static member of a type via a derived type

Check warning on line 105 in src/SoulSplitter/Migrations/Migrator.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to a static member of a type via a derived type

Access to a static member of a type via a derived type

Check warning on line 123 in src/SoulSplitter/Migrations/Migrator.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to a static member of a type via a derived type

Access to a static member of a type via a derived type

Check warning on line 77 in src/SoulSplitter/Migrations/Migrator.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to a static member of a type via a derived type

Access to a static member of a type via a derived type

Check notice on line 29 in src/SoulSplitter/Extensions.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Use preferred style of default value expression when type is not evident

Redundant type specification

Check notice on line 50 in src/SoulMemory/EldenRing/Item.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Adjust modifiers declaration order

Inconsistent modifiers declaration order

Check notice on line 107 in tests/SoulMemory.Tests/Mocks/ProcessHookMock.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Use preferred style of 'new' expression when created type is evident

Redundant type specification

Check notice on line 81 in tests/SoulMemory.Tests/Mocks/ProcessHookMock.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Use preferred style of 'new' expression when created type is evident

Redundant type specification

Check notice on line 44 in tests/SoulMemory.Tests/Mocks/ProcessHookMock.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Use preferred style of 'new' expression when created type is evident

Redundant type specification

Check notice on line 51 in tests/SoulMemory.Tests/MemoryV2/ProcessHookTests.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Use preferred style of 'new' expression when created type is evident

Redundant type specification

Check notice on line 115 in tests/SoulMemory.Tests/Mocks/ProcessHookMock.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Use preferred style of 'new' expression when created type is evident

Redundant type specification

Check notice on line 226 in src/SoulMemory/Parameters/ParamClassGenerator.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Remove redundant parentheses

Redundant parentheses

Check notice on line 486 in src/SoulMemory/EldenRing/EldenRing.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Remove redundant parentheses

Redundant parentheses

Check notice on line 81 in src/SoulMemory/DarkSouls1/Sl2Reader.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Remove redundant parentheses

Redundant parentheses

Check notice on line 115 in src/SoulMemory/soulmods/Soulmods.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Remove redundant parentheses

Redundant parentheses

Check notice on line 323 in src/SoulMemory/DarkSouls1/Ptde.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Remove redundant parentheses

Redundant parentheses

Check notice on line 166 in src/SoulMemory/ArmoredCore6/ArmoredCore6.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Remove redundant parentheses

Redundant parentheses

Check notice on line 246 in src/SoulMemory/DarkSouls3/DarkSouls3.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Remove redundant parentheses

Redundant parentheses

Check notice on line 261 in src/SoulMemory/DarkSouls3/DarkSouls3.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Remove redundant parentheses

Redundant parentheses

Check notice on line 240 in src/SoulMemory/Parameters/ParamClassGenerator.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Remove redundant parentheses

Redundant parentheses

Check notice on line 111 in src/SoulMemory/DarkSouls1/ItemReader.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Remove redundant parentheses

Redundant parentheses

Check notice on line 321 in src/SoulMemory/Sekiro/Sekiro.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Remove redundant parentheses

Redundant parentheses

Check notice on line 213 in src/SoulMemory/ArmoredCore6/ArmoredCore6.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Remove redundant parentheses

Redundant parentheses